Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for service account existing in validation #166

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Dec 13, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Add a validation rule to check if the service account for pods exists

Testing done

  • manual testing
  • new tests for the service_account_exists rule

@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch 4 times, most recently from 1bc8e0c to de4bd98 Compare December 13, 2024 00:42
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 77.35849% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (e27ffc0) to head (9526c64).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...li/src/validation/rules/service_account_missing.rs 77.08% 11 Missing ⚠️
sk-cli/src/validation/validation_store.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   72.87%   72.91%   +0.04%     
==========================================
  Files          55       56       +1     
  Lines        2971     3020      +49     
==========================================
+ Hits         2165     2202      +37     
- Misses        806      818      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch 7 times, most recently from 6e9db3b to ca1bbdf Compare December 19, 2024 03:19
@drmorr0 drmorr0 changed the base branch from master to push-nzooxqoryxru December 19, 2024 03:20
@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch from ca1bbdf to e403150 Compare December 19, 2024 03:21
@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch 2 times, most recently from 7008bbb to 04bb415 Compare December 19, 2024 05:48
Base automatically changed from push-nzooxqoryxru to master December 19, 2024 05:49
@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch from 04bb415 to ba45ec9 Compare December 19, 2024 05:52
@drmorr0 drmorr0 changed the title wip -- check service account check for service account existing in validation Dec 19, 2024
@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch 2 times, most recently from d25645e to 047cb5a Compare December 19, 2024 05:58
@drmorr0 drmorr0 force-pushed the drmorr/check-service-account branch from 047cb5a to 9526c64 Compare December 19, 2024 06:26
@drmorr0 drmorr0 merged commit 7a81987 into master Dec 19, 2024
8 checks passed
@drmorr0 drmorr0 deleted the drmorr/check-service-account branch December 19, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant