Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: annotations in skctl validate include possible patches #168

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Dec 18, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Annotations in skctl validate include a set of possible patches per event/object, instead of just an error code and affected index. This is because some proposed fixes are going to be specific to the specific state/object affected.

Testing done

  • make test
  • manual testing

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (aa21161) to head (4ede628).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sk-cli/src/validation/validation_store.rs 80.00% 1 Missing ⚠️
sk-cli/src/xray/view/helpers.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   73.02%   72.87%   -0.16%     
==========================================
  Files          55       55              
  Lines        2984     2971      -13     
==========================================
- Hits         2179     2165      -14     
- Misses        805      806       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 force-pushed the push-nzooxqoryxru branch 3 times, most recently from e2d2644 to 39f1acb Compare December 19, 2024 03:22
@drmorr0 drmorr0 merged commit e27ffc0 into master Dec 19, 2024
5 checks passed
@drmorr0 drmorr0 deleted the push-nzooxqoryxru branch December 19, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant