-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blast): add blast info to chain adapters #1652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <[email protected]>
pxrl
reviewed
Jul 2, 2024
pxrl
reviewed
Jul 2, 2024
Signed-off-by: bennett <[email protected]>
I don't want this PR to blow up in scope, so we will need to make separate PRs for the finalizer implementation. |
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
pxrl
reviewed
Jul 4, 2024
pxrl
reviewed
Jul 4, 2024
pxrl
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, subject to a couple of minor points.
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
…ions (#1662) The optimism SDK does not have predefined contract addresses for Lisk like it does for all of our other OP Stack chains. This causes finalizations to throw undefined errors. This commit adds in the necessary contract addresses which we then pass into the optimismSDK's CrossChainMessenger. We will also need to do something similar for Blast. --------- Signed-off-by: bennett <[email protected]>
pxrl
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should make all necessary changes to the finalizer and relayer so that it can send messages to Blast.