refactor(test): Split Across v3 BundleDataClient tests #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This single test file takes ~10 minutes to execute in CI and is by far the longest running test. CI can be sped up by splitting part of this test out into a separate file, such that they can be executed in parallel. This reduces the runtime for this set of tests by approximately 50%. While here, apply a couple of minor type corrections.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
nicholaspai
approved these changes
Jul 15, 2024
|
Just to add some numbers:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This single test file takes ~10 minutes to execute in CI and is by far the longest running test. CI can be sped up by splitting part of this test out into a separate file, such that they can be executed in parallel. This reduces the runtime for this set of tests by approximately 50%.
While here, apply a couple of minor type corrections.