improve(validateRunningBalances): Update script #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicholaspai
commented
Feb 4, 2025
nicholaspai
commented
- Patches a bug where slow fill amounts are counted for the wrong bundle. Currently we are subtracting the previous bundle's slow fills from the current bundle's balances, when we are expecting to subtract the current bundle's slow fills.
- Adds ability for caller to isolate a chain and token using environment variable
- Cleans up logs so that script produces much more understandable output
- Reduces default bundle count from 32 to 8 to make default run much faster
- Patches a bug where slow fill amounts are counted for the wrong bundle. Currently we are subtracting the previous bundle's slow fills from the current bundle's balances, when we are expecting to subtract the current bundle's slow fills. - Adds ability for caller to isolate a chain and token using environment variable - Cleans up logs so that script produces much more understandable output - Reduces default bundle count from 32 to 8 to make default run much faster
nicholaspai
requested review from
mrice32,
pxrl,
james-a-morris,
dohaki and
bmzig
as code owners
bmzig
previously approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.