fix(relayer): Ensure argument keys are sorted before hashing #2061
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear whether this has actually caused an issue, but implementation details at the upstream RPC provider may lead to undetected duplicate events being passed into the relayer.
pxrl
requested review from
mrice32,
nicholaspai,
james-a-morris,
dohaki and
bmzig
as code owners
nicholaspai
previously approved these changes
Feb 7, 2025
|
Marked as |
|
To be fair, we probably don't need this anymore, right? Do we still want it only if there are weird RPC quirks in the future? |
Yeah..I don't think we've been impacted by this, but in general it's probably a good idea to be consistent in how these events are handled, so I'd like to apply sorting. |
|
@bmzig wdyt about this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear whether this has actually caused an issue, but implementation details at the upstream RPC provider may lead to undetected duplicate events being passed into the relayer.