Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Add tag output~ #10

Closed
wants to merge 43 commits into from
Closed

Add tag output~ #10

wants to merge 43 commits into from

Conversation

monkeyWie
Copy link

@monkeyWie monkeyWie commented Oct 22, 2019

Hello,as you said,parsing the refs/tags/xxx is a matter in workflow,so I re open this PR.

@csexton
Copy link
Contributor

csexton commented Oct 22, 2019

Oh, this is handy 😍

dist/index.js Outdated
core.setFailed(error.message);
}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here? Spaces to tabs or vice-versa?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist/index.js Is this file auto-generated by build? @monkeyWie Can you help fix it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I revertdist / index.js and build it by author self?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IAmHughes Help to merge this pr, pls.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deancn dist/index.js is created and added to the commit by npm run precommit, which is run by a pre-commit Git hook added by husky when you npm install the project. You should not edit it yourself, but instead fix errors in src/.

@monkeyWie
Copy link
Author

@jnovack @IAmHughes I have resolved the conflict,please review again.

@pplavetzki
Copy link

Any update on this? Would be most useful to only have the tag_name and not the /ref/tags/tag_name

bryanjswift added a commit to bryanjswift/Paw-TicketEvolutionXSignature that referenced this pull request Feb 20, 2020
The `create-release` action strips out the `refs/tags/` from the
beginning of `github.ref` and does not provide the tag name as an
output (yet see actions/create-release#10).
IAmHughes and others added 20 commits April 17, 2020 08:15
…ndlebars-4.5.3

Bump handlebars from 4.2.1 to 4.5.3
…orn-5.7.4

Bump acorn from 5.7.3 to 5.7.4
Update readme example to pin to major version
body_path missing from action.yml
Changed release name to be optional field
…commitish

Tag and release on a specific commitish
create release with body text sourced from file
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>
…dash-4.17.19

Bump lodash from 4.17.15 to 4.17.19
@balcsida
Copy link

Hi folks,

Could you please check on this PR, please?
This would greatly improve my workflows - uploading versioned ZIP files is sick :D

Kind regards,
@balcsida

@jnovack
Copy link

jnovack commented Sep 15, 2020

Won't review until all conflicts are resolved. dist/index.js looks like a mess in the diff editor.

@monkeyWie monkeyWie mentioned this pull request Sep 17, 2020
@monkeyWie
Copy link
Author

Reopen a PR:#97

@monkeyWie monkeyWie closed this Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.