Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate cache service v2 #1857
base: main
Are you sure you want to change the base?
Integrate cache service v2 #1857
Changes from 37 commits
32dbccb
264230c
c8466d1
66d5434
dccc3f7
6635d12
146143a
9e63a77
5e5faf7
5afc042
8d7ed4f
7640cf1
e1b7e78
04d1a7e
4902d3a
70e5684
07e51a4
e62c642
13abc95
4d1dedf
d399e33
89354f6
28dbd8f
01bf918
75cdb2c
9da70ff
4e1912a
d109d9c
9dff82c
69409b3
b2557ac
19cdd5f
83baffc
2ee77e6
c3e354d
ea4bf48
5e9ef85
ab8110f
555b03f
68ab87c
6c11d44
3ca8547
8616c31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an opportunity to share code between
restoreCachev1
andrestoreCachev2
instead of duplicating it all?That would make it easier to see what's actually changing and improve long-term maintenance of supporting both paths (such as for GHES).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's easier to reason about what each function is doing this way. We don't have to couple the behaviour of each with more shared functions. The utility functions are already extracted, and what remains is the procedural implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need these in the request if they're encoded into the JWT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in: https://github.com/github/actions-relaunch/issues/994