Improve messaging when the API fails to download a file (#1396)

actualbudget · Jul 24, 2023 · 9c527e3 · 9c527e3
1 parent b8c90aa
commit 9c527e3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.ts
@@ -204,6 +204,7 @@ handlers['api/download-budget'] = async function ({ syncId, password }) {
 
     let result = await handlers['download-budget']({ fileId: file.fileId });
     if (result.error) {
+      console.log('Full error details', result.error);
       throw new Error(getDownloadError(result.error));
     }
     await handlers['load-budget']({ id: result.id });

diff --git a/packages/loot-core/src/shared/errors.ts b/packages/loot-core/src/shared/errors.ts
@@ -51,10 +51,11 @@ export function getDownloadError({ reason, meta, fileName }) {
       );
 
     default:
-      let info = meta && meta.fileId ? `(fileId: ${meta.fileId})` : '';
+      let info = meta && meta.fileId ? `, fileId: ${meta.fileId}` : '';
       return (
-        'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. ' +
-        info
+        'Something went wrong trying to download that file, sorry! ' +
+        'Visit https://actualbudget.org/contact/ for support. ' +
+        `(reason: ${reason}${info})`
       );
   }
 }

diff --git a/upcoming-release-notes/1396.md b/upcoming-release-notes/1396.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [j-f1]
+---
+
+Improve error messaging when the API package fails to download a file