Update node-fetch in the API to fix connection drop issue #1397

j-f1 · 2023-07-24T20:28:34Z

We’ll now hint that the file ID might be incorrect if that’s the type of error we get.

Fixes #1394 by updating node-fetch (unconfirmed)

netlify · 2023-07-24T20:28:39Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`2f6e090`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/64c4fe8df3b54500088c9821
😎 Deploy Preview	https://deploy-preview-1397.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-07-24T20:32:08Z

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.08 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/main.js	848.64 KB	0%
static/js/457.chunk.js	388.22 KB	0%
static/media/Inter-italic.var.woff2	239.29 KB	0%
static/media/Inter-roman.var.woff2	221.86 KB	0%
static/js/wide-components.chunk.js	159.28 KB	0%
static/js/383.chunk.js	117.35 KB	0%
static/js/reports.chunk.js	32.25 KB	0%
static/js/narrow-components.chunk.js	31.94 KB	0%
static/js/281.chunk.js	28.55 KB	0%
static/js/876.chunk.js	26.2 KB	0%
static/js/969.chunk.js	12.94 KB	0%
static/js/resize-observer-polyfill.chunk.js	8.12 KB	0%
static/css/main.css	5.82 KB	0%
asset-manifest.json	2.07 KB	0%
index.html	1.66 KB	0%
static/media/browser-server.js	963 B	0%

github-actions · 2023-07-24T20:32:09Z

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	1.97 MB -> 1.97 MB (+147 B)	+0.01%

Changeset

File	Δ	Size
`packages/loot-core/src/server/cloud-storage.ts`	📈 +157 B (+1.43%)	10.69 KB -> 10.84 KB
`packages/loot-core/src/platform/server/fetch/index.web.ts`	📉 -88 B (-69.84%)	126 B -> 38 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1010.95 KB -> 1011.09 KB (+147 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
xfo.xfo.kcab.worker.js	1004.04 KB	0%

MatissJanis · 2023-07-25T17:01:50Z

Oops.. you added the stats.json file.

j-f1 · 2023-07-25T18:59:03Z

Good catch!

toebbel

I can confirm that fixed connection issues to instances of actual-server running on fly.io

MatissJanis · 2023-07-28T18:25:09Z

packages/api/test.js

@@ -1,8 +1,9 @@
-import * as api from './index';
+let api = require('./dist/index');


Tests shouldn't rely on the compiled code, but instead the source. Any way we can change this back?

IMO this should be testing the compiled code to make sure that it actually behaves correctly. It isn’t automatically run at this point (#1074) but running directly against the source somehow could give us false confidence.

Actually.. this file is not even used. So I would vote to kill it off entirely.

Even when we add proper tests to api: it won't really make much sense since it's not really a unit test or a e2e test. Just some weird leftover I think.

j-f1 · 2023-07-29T12:25:29Z

Can you do a release? (Also fine to wait if you want to do it with the other August releases)

MatissJanis · 2023-07-29T19:32:26Z

Lets do it with August release.

…et#1397)

Add yet more error logging

c20a8fd

trafico-bot bot added the 🔍 Ready for Review label Jul 24, 2023

Add release note

09a2437

MatissJanis approved these changes Jul 24, 2023

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Jul 24, 2023

j-f1 added 2 commits July 25, 2023 14:56

Update to node-fetch 3

e6d3ae0

ignore API stats.json file

e2a9329

j-f1 force-pushed the jed/more-logging branch from 4a205b9 to e2a9329 Compare July 25, 2023 18:58

Update release note

f0902ec

j-f1 changed the title ~~Add yet more error logging when downloading a file from the server~~ Update node-fetch in the API to fix connection drop issue Jul 25, 2023

j-f1 added 3 commits July 25, 2023 16:18

Remove unused fetchBinary

fbdc5af

Fix require() of esm error

de09fca

Fix import() transform

553b585

MatissJanis approved these changes Jul 26, 2023

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Jul 26, 2023

swap self for globalThis

9486ef1

trafico-bot bot added 🔍 Ready for Review and removed ✅ Approved labels Jul 27, 2023

j-f1 added 3 commits July 27, 2023 11:37

Add build:api global script

24d8d7e

Fix api/test.js

2111a85

Fix lint error

74db110

toebbel approved these changes Jul 28, 2023

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Jul 28, 2023

j-f1 requested a review from MatissJanis July 28, 2023 17:36

MatissJanis reviewed Jul 28, 2023

View reviewed changes

Delete test.js

2f6e090

trafico-bot bot added 🔍 Ready for Review and removed ✅ Approved labels Jul 29, 2023

MatissJanis approved these changes Jul 29, 2023

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Jul 29, 2023

j-f1 merged commit a99e88b into master Jul 29, 2023

j-f1 deleted the jed/more-logging branch July 29, 2023 12:24

trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 29, 2023

FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024

Update node-fetch in the API to fix connection drop issue (actualbudg…

0a6bfb9

…et#1397)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update node-fetch in the API to fix connection drop issue #1397

Update node-fetch in the API to fix connection drop issue #1397

j-f1 commented Jul 24, 2023 •

edited

Loading

netlify bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

MatissJanis commented Jul 25, 2023

j-f1 commented Jul 25, 2023

toebbel left a comment

MatissJanis Jul 28, 2023

j-f1 Jul 28, 2023

MatissJanis Jul 29, 2023

j-f1 Jul 29, 2023

j-f1 commented Jul 29, 2023

MatissJanis commented Jul 29, 2023

		@@ -1,8 +1,9 @@
		import * as api from './index';
		let api = require('./dist/index');

Update node-fetch in the API to fix connection drop issue #1397

Update node-fetch in the API to fix connection drop issue #1397

Conversation

j-f1 commented Jul 24, 2023 • edited Loading

netlify bot commented Jul 24, 2023 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jul 24, 2023 • edited Loading

Bundle Stats - desktop-client

github-actions bot commented Jul 24, 2023 • edited Loading

Bundle Stats - loot-core

MatissJanis commented Jul 25, 2023

j-f1 commented Jul 25, 2023

toebbel left a comment

Choose a reason for hiding this comment

MatissJanis Jul 28, 2023

Choose a reason for hiding this comment

j-f1 Jul 28, 2023

Choose a reason for hiding this comment

MatissJanis Jul 29, 2023

Choose a reason for hiding this comment

j-f1 Jul 29, 2023

Choose a reason for hiding this comment

j-f1 commented Jul 29, 2023

MatissJanis commented Jul 29, 2023

j-f1 commented Jul 24, 2023 •

edited

Loading

netlify bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading