in5piration-board - Sea Turtle Group 5 (Danielle, Gelly, Olive, Tiffini) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom_json class method to Board
| from app.models.board import Board | ||
| from .routes_helper import get_record_by_id, make_record_safely | ||
|
|
||
| card_bp = Blueprint('card_bp', __name__, url_prefix="/boards/") |
There was a problem hiding this comment.
For clarity of naming, if the routes in this file are all prefixed with boards I might consider naming the file something like board_card_routes to help imply the nesting.
I would also consider, should all the routes be nested under /boards? The routes to delete and like a card don't require a board id, so it could make sense to simplify those routes to something like /cards/<card_id>.
| @@ -0,0 +1,23 @@ | |||
| from flask import jsonify, abort, make_response | |||
|
|
|||
| def error_message(message, status_code): | |||
| assert response.status_code == 200 | ||
| assert len(Board.query.get(1).cards) == 2 | ||
|
|
||
| def test_like_card(client, one_card): |
There was a problem hiding this comment.
Nice test suite! Some other considerations could be around what happens when you like a card that doesn't exist, or when you try to add a card to a board that doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.