Whales - Gaby Webb #106
Open
Whales - Gaby Webb #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jul 1, 2022
| @@ -1,15 +1,205 @@ | |||
| export const drawLetters = () => { | |||
| // Implement this method for wave 1 | |||
| const letterPool = [ | |||
There was a problem hiding this comment.
This was a really good way to make sure you had the proper distribution of letters.
Sometimes it really does make sense to go for something simple like this. It's kind of beautifully simple. 😃
| }; | ||
|
|
||
| for (let i = 0; i < wordsLen; i++) { | ||
| let selectedWord = words[i]; |
There was a problem hiding this comment.
Since this is a variable inside a loop it can be const you've made excellent use of const everywhere else so I figured I'd point it out. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.