Sea Turtles/Theresa Davis #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 15, 2022
| 'Z': 10 | ||
| } | ||
|
|
||
| export const generateRandomLetter = function (){ |
| let letters = []; | ||
| let i = 0; | ||
| let letterPool = {}; | ||
| const LETTER_POOL= { |
There was a problem hiding this comment.
you already have a letterPool constant so you don't need this one
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| }; | ||
| let wordFreqMap = {}; |
Comment on lines
+124
to
+133
| newWord.forEach(item =>{ | ||
| if (wordFreqMap[item]){ | ||
| wordFreqMap[item] ++; | ||
| }else{ | ||
| wordFreqMap[item]= 1; | ||
| } | ||
| return wordFreqMap | ||
| }); | ||
|
|
||
| lettersInHand.forEach(item =>{ |
There was a problem hiding this comment.
Here you are performing similar operations for frequency maps for newWord and lettersInHand, this means you could create a helper function that takes in a string and returns a frequency map of letters
Comment on lines
+173
to
+175
| if(capWord.length >= 7 ){ | ||
| totalScore += 8; | ||
| } |
There was a problem hiding this comment.
this could also be a ternary operator
let totalScore = capWord.length >= 7 ? 8 : 0;then replace line 167 with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.