Sharks: Gricelda #113
Sharks: Gricelda #113
Conversation
| @@ -1,15 +1,158 @@ | |||
| const LETTER_POOL = { | |||
There was a problem hiding this comment.
Nice job following JS convention for naming variables that are constants.
| const letters = Object.keys(LETTER_POOL); | ||
|
|
||
| // letterPool list and then append(push) for each letter in the letter_Pool into the list(array) | ||
| let letterPool = []; | ||
| letters.forEach(function (letter) { | ||
| for (let i = 0; i < LETTER_POOL[letter]; i++) { | ||
| letterPool.push(letter); | ||
| } | ||
| }); |
| // then we need to push the newLetterpool into hand | ||
| // return hand array | ||
| let hand = []; | ||
| let newLetterpool = [...letterPool]; |
| // if empty must return 0 | ||
| const inputArray = input.split(""); | ||
| const inputLength = input.length; | ||
| let letterInHand = [...lettersInHand]; |
There was a problem hiding this comment.
I think this line is making a copy of lettersInHand so that you can use letterInHand to splice from it without mutating the array that's passed into the method.
Consider renaming letterInHand to something like copyOfLetters since the two variable names above are so similar looking - letterInHand just has one less 's' so it compromises readability a little bit
| let score = 0; | ||
| for (let i = 0; i < inputLength; i++) { | ||
| let letter = inputArray[i]; | ||
| if (letters.includes(letter)) { |
There was a problem hiding this comment.
Nice check here!
If a letter isn't in letters then if you when line 118 executes, calling letterScore[letter] would return undefined on the right side. Adding undefined to an integer would return NaN and would introduce a bug.
| if (inputLength > 6 && inputLength < 11) { | ||
| score += 8; | ||
| } |
There was a problem hiding this comment.
You could also refactor line 114 when you first declare score to precalculate the bonus for a long word.
let score = word.length >= 7 ? 8 : 0;| expectScores({ | ||
| '': 0, | ||
| }); |
| const inputArray = input.split(""); | ||
| const inputLength = input.length; | ||
| let letterInHand = [...lettersInHand]; | ||
| for (let i = 0; i < inputLength; i++) { |
There was a problem hiding this comment.
Since i isn't being reassigned in the for loop, we can use const instead. Whenever you write a loop, you can check to see if the variable, like i or whatever variable you name the element, is being updated in the for loop. If it's not, then we should use const
No description provided.