Esther Annorzie - Sea Turtles #97

estherannorzie · 2022-06-07T16:28:34Z

Finished wave 1-3

… the array

…word and score key

…breaking word

kelsey-steven-ada

Good work overall, Esther! I've left some comments and suggestions, please take a look when you can and let me know if there's anything I can clarify =]

kelsey-steven-ada · 2022-06-10T03:58:00Z

src/adagrams.js

+  // something is up with my condition here
+  for (let i = word_scores.length; i < word_scores.length; i -= 2) {


Right now i starts at word_scores.length, and our loop checks if i < word_scores.length to decide if we should leave the loop. Since we decrement i by 2 each iteration, i is never greater than word_scores.length, so we never leave the loop. Since the last index we want to hit is 1, if we change the condition statement to ensure we stop at 1, we'll leave the loop as expected.

Since javascript arrays also uses 0-based indexing, we would want to start i at word_scores.length - 1 since it would be the last index.

kelsey-steven-ada · 2022-06-10T04:06:10Z

src/adagrams.js

+  }
+
+  return {
+    word: word_scores.indexOf(max_score) - 1, 


.indexOf(max_score) will return us the first word it finds in the list word_scores with the score max_score, even if by our tie breaking rules there might be a shorter string with the same score later in the list we would want to return.

kelsey-steven-ada · 2022-06-10T04:11:22Z

src/adagrams.js

+    word_scores.push(scoreWord(words[i]))
+  }
+
+  let max_score = 0;


So that we can break ties between words with the same score, we might also want to create a list variable that we fill with all the words with a score of max_score.

kelsey-steven-ada · 2022-06-10T23:26:01Z

src/adagrams.js

+  // not able to create a shuffling algo myself
+  // Fisher-Yates shuffle algorithm
+  // https://masteringjs.io/tutorials/fundamentals/shuffle#:~:text=To%20properly%20shuffle%20an%20array%20in%20JavaScript%2C%20use,random%20element%20in%20the%20array%20as%20shown%20below.
+  for (let i = letters.length - 1; i >= 1; i--) {
+    let j = Math.floor(Math.random() * (i + 1));
+    let temp = letters[j];
+    letters[j] = letters[i];
+    letters[i] = temp;
+  };
+  return letters.slice(0, 10);


Creating a proper shuffling algorithm can be a significant problem to solve. We could use the letters array in another approach to create a hand.

If we create an empty list hand, we could fill it by looping 10 times and in each iteration:

create a random number between 0 and the last index of the letters array

Get the letter at our random index from the letter list

Push that letter onto our hand array

Use something like splice to remove the letter at our random index from the letter array so the letter can't be used twice

At the end of our loop we'll have a full hand array and can return it!

kelsey-steven-ada · 2022-06-10T23:30:13Z

src/adagrams.js

+  let inputLetterFreq = {};
+  for (const letter of input) {
+    if (letter.toUpperCase() in inputLetterFreq) {
+      inputLetterFreq[letter.toUpperCase()] += 1;
+    } else {
+      inputLetterFreq[letter.toUpperCase()] = 1;
+    }
+  };
+
+  let lettersInHandFreq = {};
+  for (const letter of lettersInHand) {
+    if (letter.toUpperCase() in lettersInHandFreq) {
+      lettersInHandFreq[letter.toUpperCase()] += 1;
+    } else {
+      lettersInHandFreq[letter.toUpperCase()] = 1;
+    }
+  };


We perform similar operations to create frequency maps for input and lettersInHand, this would be a great candidate for a helper function that takes in a string and returns a frequency map of the letters.

kelsey-steven-ada · 2022-06-11T00:10:04Z

src/adagrams.js

@@ -1,15 +1,177 @@
 export const drawLetters = () => {
  // Implement this method for wave 1
+  const scoreChart = {


I think we'd want to rename this something like letterPool or availableLetters to better reflect what it holds.

kelsey-steven-ada · 2022-06-11T00:11:10Z

src/adagrams.js

 };

 export const scoreWord = (word) => {
  // Implement this method for wave 3
+  const scoreChart = {


Nice keeping the scoring and available letter objects inside the functions where they're used!

kelsey-steven-ada · 2022-06-11T00:13:25Z

src/adagrams.js

+  for (const letter of word) {
+    if (letter.toUpperCase() in scoreChart) {
+      score += scoreChart[letter.toUpperCase()];
+    }
+  }


Neat implementation of feedback from the python version!

kelsey-steven-ada · 2022-06-11T00:14:23Z

test/adagrams.test.js

@@ -145,7 +146,8 @@ describe("Adagrams", () => {
      const words = ["XXX", "XXXX", "X", "XX"];
      const correct = { word: "XXXX", score: scoreWord("XXXX") };

-      throw "Complete test by adding an assertion";
+      // throw "Complete test by adding an assertion";
+      expect(highestScoreFrom(words)).toEqual(correct);


kelsey-steven-ada · 2022-06-11T00:20:43Z

.vscode/settings.json

@@ -0,0 +1,6 @@
+{


This looks like a workspace specific settings file. If we see unexpected new files added to a PR, we usually want to double check if they're necessary and remove them from being tracked by git if not. It's not something we need to worry about for our projects, but it can come up when working on a shared code base.

If a file is not already being tracked by git we can list it in the .gitignore file and git will know never to track it, but if git is already tracking a file (like this one), telling it to stop and removing it from tracking takes a step or two. This stack overflow talks about how you can remove a file from being tracked if you're interested: https://stackoverflow.com/questions/1274057/how-can-i-make-git-forget-about-a-file-that-was-tracked-but-is-now-in-gitign

estherannorzie added 26 commits June 5, 2022 15:07

Created scoreChart variable to hold letter distribution

c741f96

Able to draw ten letters from pool and return an array

4880f36

Added shuffle algorithm for drawLetters

29b6ebb

Created frequency map for input and lettersInHand, 1 test passes

7b3c719

Adjusted input loop to compare input frequencies

2934cd0

Implemented scoreChart for scoreWord

af5d6d0

Added uppercasing for wave 3 loop

1b5f735

Added assertion for empty input in wave 3

a836570

Created score variable to hold scoreWord return value

075cca8

Created an array to hold score and loop to added each word's score to…

9d4dd59

… the array

Added shuffling algorithm source

a59e847

Started pseudocode for highestScoreFrom

09fd913

Formatted pseudocode

ab2fbd4

Fixed for loop to create array of word scores in highestScoreFrom

47ee11c

Create loop to check for highest score in array, returns object with …

7d77e1c

…word and score key

Removed stray import

76e0931

Changed highestScoreFrom max score looping length

1407b18

Fixed off-by-one error in highestScoreFrom loop

2ec2f47

Adjusted syntax of return in highestScoreFrom

802f984

Adjusted highestScoreFrom to loops correctly, started working on tie …

f0692cf

…breaking word

Renamed highestScoreFrom variables to camel case

52f0778

Deleted some comments and whitespace

a02d19d

Added assertion to highestScoreFrom test

f613888

Added pseudocode to highestScoreFrom

b666e82

Separated maxWords into new logic/for loop

c1e7ada

Renamed variable name for tied words array

6d8a769

kelsey-steven-ada reviewed Jun 11, 2022

View reviewed changes

estherannorzie added 3 commits June 10, 2022 20:58

Changed wordScores loops to iterate forward, passed wave 4

50d4bad

Renamed scoreChart to availableLetters, remove stray file

944c72a

Edited gitignore

22307c0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Esther Annorzie - Sea Turtles #97

Esther Annorzie - Sea Turtles #97

estherannorzie commented Jun 7, 2022

kelsey-steven-ada left a comment

kelsey-steven-ada Jun 10, 2022

kelsey-steven-ada Jun 10, 2022

kelsey-steven-ada Jun 10, 2022

kelsey-steven-ada Jun 10, 2022

kelsey-steven-ada Jun 10, 2022

kelsey-steven-ada Jun 11, 2022

kelsey-steven-ada Jun 11, 2022

kelsey-steven-ada Jun 11, 2022

kelsey-steven-ada Jun 11, 2022

kelsey-steven-ada Jun 11, 2022

		// something is up with my condition here
		for (let i = word_scores.length; i < word_scores.length; i -= 2) {

Esther Annorzie - Sea Turtles #97

Are you sure you want to change the base?

Esther Annorzie - Sea Turtles #97

Conversation

estherannorzie commented Jun 7, 2022

kelsey-steven-ada left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment