san chatlog #102
Open
san chatlog #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jul 12, 2022
| import chatMessages from './data/messages.json'; | ||
|
|
||
| const App = () => { | ||
| const [chatMessagesData, setChatData] = useState(chatMessages); | ||
|
|
||
| const updateChatData = (updatedMessage) => { |
| }; | ||
|
|
||
|
|
||
| const countLikes = (messages) => { |
There was a problem hiding this comment.
This is a great way to use existing data. You could also use the reduce function
return messageData.reduce((totalLikes, message) => {
// If messages.liked is true add 1 to totalLikes, else add 0
return (totalLikes += message.liked ? 1 : 0);
}, 0); // The 0 here sets the initial value of totalLikes to 0| <header> | ||
| <h1>Application title</h1> | ||
| <h1>A tale of two cities</h1> | ||
| <section><span id="heartWidget" className="widget"> {likes} 💚s</span></section> |
There was a problem hiding this comment.
You could just call your function in jsx like {countLikes(chatMessageData} and in Learn you were getting an error message because of the style of heart you are using. You can alter the tests to accept the heart you want to use.
| props.onUpdate(updatedMessage); | ||
| } | ||
|
|
||
| const likeButton = props.liked ? '💚' : '🤍'; |
There was a problem hiding this comment.
nice use of ternary operator here. Your test are currently looking for ❤️. If you don't want to use that update your tests to reflect that.
|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.arrayOf( | ||
| PropTypes.shape({ |
There was a problem hiding this comment.
great way to specific about what the objects content should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.