C17 Otters - Ada Barries #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (entry.id === id) { | ||
| entry.liked = !entry.liked; | ||
| if (entry.liked) { | ||
| likeCount += 1; |
There was a problem hiding this comment.
Careful not to update the state variable directly! This could have unintended side effects. You should always use the setState() (or in this case setLikes()) function.
Here's a good discussion on this: https://stackoverflow.com/questions/37755997/why-cant-i-directly-modify-a-components-state-really
Alsoooo your app currently only increases likeCount and it doesn't handle situations where someone unlikes a message. I don't think this was explicitly stated as a requirement for the project, but I'm mentioning it since it is still good to pay attention to stuff like this.
|
|
||
|
|
||
| const ChatLog = (props) => { | ||
| const chatComponents = props.entries.map((entry) => { |
| let [likeCount, setLikes] = useState(0); | ||
|
|
||
| const changeHeartColor = (id) => { | ||
| const newEntries = entries.map((entry) => ({...entry})); |
There was a problem hiding this comment.
Nice copy! As a heads up, you can create a copy with Destructuring alone like this:
const newEntries = [...entries];
| <button className="like">🤍</button> | ||
| <p>{props.body}</p> | ||
| <TimeStamp className="entry-time" time={props.timeStamp}></TimeStamp> | ||
| <button className="like" onClick={heartToggle}>{props.liked ? '❤️' : '🤍' }</button> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.