-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sea Turtles Natalia Woodson #90
base: main
Are you sure you want to change the base?
Changes from all commits
1576f23
366b0f1
18afe23
18440a3
2321473
daef773
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,53 @@ | ||
import React from 'react' | ||
import App from './App' | ||
import { render, screen, fireEvent } from '@testing-library/react' | ||
import React from 'react'; | ||
import App from './App'; | ||
import { render, screen, fireEvent } from '@testing-library/react'; | ||
|
||
describe('Wave 03: clicking like button and rendering App', () => { | ||
test('that the correct number of likes is printed at the top', () => { | ||
// Arrange | ||
const { container } = render(<App />) | ||
let buttons = container.querySelectorAll('button.like') | ||
const { container } = render(<App />); | ||
let buttons = container.querySelectorAll('button.like'); | ||
|
||
// Act | ||
fireEvent.click(buttons[0]) | ||
fireEvent.click(buttons[1]) | ||
fireEvent.click(buttons[10]) | ||
fireEvent.click(buttons[0]); | ||
fireEvent.click(buttons[1]); | ||
fireEvent.click(buttons[10]); | ||
|
||
// Assert | ||
const countScreen = screen.getByText(/3 ❤️s/) | ||
expect(countScreen).not.toBeNull() | ||
}) | ||
const countScreen = screen.getByText(/3 ❤️s/); | ||
expect(countScreen).not.toBeNull(); | ||
}); | ||
|
||
test('clicking button toggles heart and does not affect other buttons', () => { | ||
// Arrange | ||
const { container } = render(<App />) | ||
const buttons = container.querySelectorAll('button.like') | ||
const firstButton = buttons[0] | ||
const lastButton = buttons[buttons.length - 1] | ||
const { container } = render(<App />); | ||
const buttons = container.querySelectorAll('button.like'); | ||
const firstButton = buttons[0]; | ||
const lastButton = buttons[buttons.length - 1]; | ||
|
||
// Act-Assert | ||
|
||
// click the first button | ||
fireEvent.click(firstButton) | ||
expect(firstButton.innerHTML).toEqual('❤️') | ||
fireEvent.click(firstButton); | ||
expect(firstButton.innerHTML).toEqual('❤️'); | ||
|
||
// check that all other buttons haven't changed | ||
for (let i = 1; i < buttons.length; i++) { | ||
expect(buttons[i].innerHTML).toEqual('🤍') | ||
expect(buttons[i].innerHTML).toEqual('🤍'); | ||
} | ||
|
||
// click the first button a few more times | ||
fireEvent.click(firstButton) | ||
expect(firstButton.innerHTML).toEqual('🤍') | ||
fireEvent.click(firstButton) | ||
expect(firstButton.innerHTML).toEqual('❤️') | ||
fireEvent.click(firstButton) | ||
expect(firstButton.innerHTML).toEqual('🤍') | ||
fireEvent.click(firstButton); | ||
expect(firstButton.innerHTML).toEqual('🤍'); | ||
fireEvent.click(firstButton); | ||
expect(firstButton.innerHTML).toEqual('❤️'); | ||
fireEvent.click(firstButton); | ||
expect(firstButton.innerHTML).toEqual('🤍'); | ||
|
||
// click the last button a couple times | ||
fireEvent.click(lastButton) | ||
expect(lastButton.innerHTML).toEqual('❤️') | ||
fireEvent.click(lastButton) | ||
expect(lastButton.innerHTML).toEqual('🤍') | ||
}) | ||
}) | ||
fireEvent.click(lastButton); | ||
expect(lastButton.innerHTML).toEqual('❤️'); | ||
fireEvent.click(lastButton); | ||
expect(lastButton.innerHTML).toEqual('🤍'); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,50 @@ | ||
import React from 'react'; | ||
import './ChatEntry.css'; | ||
import PropTypes from 'prop-types'; | ||
import TimeStamp from './TimeStamp'; | ||
|
||
const ChatEntry = (props) => { | ||
const heartStatus = props.liked ? '❤️' : '🤍'; | ||
let entrySide = | ||
props.sender === 'Vladimir' ? 'chat-entry local' : 'chat-entry remote'; | ||
|
||
let color = | ||
props.sender === 'Vladimir' ? props.localTextColor : props.remoteTextColor; | ||
|
||
const handleLike = () => { | ||
const updatedEntry = { | ||
id: props.id, | ||
sender: props.sender, | ||
body: props.body, | ||
liked: !props.liked, | ||
timeStamp: props.timeStamp, | ||
}; | ||
props.onUpdate(updatedEntry); | ||
}; | ||
|
||
return ( | ||
<div className="chat-entry local"> | ||
<h2 className="entry-name">Replace with name of sender</h2> | ||
<div className={entrySide}> | ||
<h2 className="entry-name">{props.sender}</h2> | ||
<section className="entry-bubble"> | ||
<p>Replace with body of ChatEntry</p> | ||
<p className="entry-time">Replace with TimeStamp component</p> | ||
<button className="like">🤍</button> | ||
<p className={color}>{props.body}</p> | ||
<p className="entry-time"> | ||
<TimeStamp time={props.timeStamp} /> | ||
</p> | ||
<button className="like" onClick={handleLike}> | ||
{heartStatus} | ||
</button> | ||
</section> | ||
</div> | ||
); | ||
}; | ||
|
||
ChatEntry.propTypes = { | ||
//Fill with correct proptypes | ||
id: PropTypes.number.isRequired, | ||
sender: PropTypes.string, | ||
body: PropTypes.string, | ||
timestamp: PropTypes.string, | ||
liked: PropTypes.bool, | ||
onUpdate: PropTypes.func.isRequired, | ||
Comment on lines
+42
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In Learn, we are seeing errors for some of your propTypes. I would only use isRequired on the props that must be passed for the component to render to pass the tests. In this case, the only required props would be the sender, body, timeStamp props. |
||
}; | ||
|
||
export default ChatEntry; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import ChatEntry from './ChatEntry'; | ||
import PropTypes from 'prop-types'; | ||
|
||
const ChatLog = (props) => { | ||
const chatEntries = props.entries.map((entry) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can use index with map. This should get rid of your key on each child error. const chatEntries = prop.entries.map((entry, i) =>
...
<ChatEntry
key={i} |
||
return ( | ||
<ChatEntry | ||
key={entry.id} | ||
id={entry.id} | ||
sender={entry.sender} | ||
body={entry.body} | ||
timeStamp={entry.timeStamp} | ||
liked={entry.liked} | ||
onUpdate={props.onUpdateChat} | ||
localTextColor={props.onUpdateLocal} | ||
remoteTextColor={props.onUpdateRemote} | ||
></ChatEntry> | ||
); | ||
}); | ||
return <section className="chat-log">{chatEntries}</section>; | ||
}; | ||
|
||
ChatLog.propTypes = { | ||
entries: PropTypes.array.isRequired, | ||
onUpdateChat: PropTypes.func.isRequired, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
}; | ||
|
||
export default ChatLog; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
|
||
const ColorChoice = (props) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love this added feature! |
||
const setColorCallback = (event) => { | ||
if (props.onUpdateLocal) { | ||
props.onUpdateLocal(event.currentTarget.id); | ||
} else { | ||
props.onUpdateRemote(event.currentTarget.id); | ||
} | ||
}; | ||
|
||
const getButtonsMap = () => { | ||
const colors = { | ||
red: '🔴', | ||
yellow: '🟡', | ||
purple: '🟣', | ||
green: '🟢', | ||
orange: '🟠', | ||
blue: '🔵', | ||
}; | ||
return Object.entries(colors).map(([key, value]) => { | ||
return ( | ||
<button onClick={setColorCallback} key={key} id={key}> | ||
{value} | ||
</button> | ||
); | ||
}); | ||
}; | ||
return <div>{getButtonsMap()}</div>; | ||
}; | ||
|
||
ColorChoice.propTypes = { | ||
onUpdateLocal: PropTypes.func, | ||
onUpdateRemote: PropTypes.func, | ||
}; | ||
|
||
export default ColorChoice; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽