allows you to benchmark against 1 chosen URL. #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aarch64 is once again failing with a constexpr issue... |
anonrig
reviewed
Sep 28, 2024
| @@ -7,7 +7,11 @@ double url_examples_bytes{}; | |||
|
|
|||
| std::vector<std::pair<std::string, std::string>> url_examples; | |||
|
|
|||
| size_t init_data(const char *source) { | |||
| enum { | |||
| ALL_URLS = -1, | |||
There was a problem hiding this comment.
Can you also add a documentation on how to run the benchmarks?
There was a problem hiding this comment.
@anonrig I pushed another commit which I expect might fix this build issue.
|
@anonrig Regarding documentation, have you seen this? 
Note that though it is not well documented, we can also filter benchmarks.. But that's Google Benchmark stuff. (And it was not previously documented.) Note that the command line processing is not great in these tools. It is kind of a hack, but we don't expect most users to care about these details. |
|
I see it is still failing the aarch64 ... :-/ |
anonrig
approved these changes
Sep 28, 2024
|
@lemire it seems aarch64 is still failing. would you mind taking a look into it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies slightly one of our benchmark program so that we can narrowly benchmark URLs one by one if needed.