Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Component Request: BH1745 #116

Open
brentru opened this issue Jan 13, 2023 · 3 comments
Open

[REQ] Component Request: BH1745 #116

brentru opened this issue Jan 13, 2023 · 3 comments
Labels

Comments

@brentru
Copy link
Member

brentru commented Jan 13, 2023

What's the full name of the component you'd like to see in Adafruit.io WipperSnapper?
BH1745 Ambient Light Sensor

What type of component is this (i.e.: Pin, I2C)?
I2C

Product URL or Datasheet
https://www.mouser.co.uk/datasheet/2/348/bh1745nuc-e-519994.pdf

Additional context
Used in the Enviro Indoor, https://shop.pimoroni.com/products/enviro-indoor?variant=40055644717139

@whatisbyandby
Copy link
Contributor

Hi,
I have a BH1745 on hand, and would like to try to implement this components. It sounds like the first step to adding a component is creating a PR here with the JSON definition. Then another PR for the driver over here in the Wippersnapper Arduino repo. Can I go ahead and open the PR for the JSON first, or should I wait until I have the driver complete as well?

@brentru
Copy link
Member Author

brentru commented Jul 7, 2023

Can I go ahead and open the PR for the JSON first, or should I wait until I have the driver complete as well?

Let's open a PR for the JSON first.

Within the definition, AHT20 for example:

{
  "displayName": "AHT20",
  "published": true,
  "i2cAddresses": [ "0x38" ],
  "subcomponents": [ "ambient-temp", "ambient-temp-fahrenheit", "humidity" ]
}

Change "published": true to: "published": false

Once we merge the definition into this repository, checking the "Show Dev?" button on the Adafruit IO component picker will let you see your component and test out your driver against io.adafruit.com to ensure it works correctly.

When you're happy with how it all works, open a PR for the driver. We'll make the component visible to everyone, not just developers when we cut a new release of WipperSnapper firmware.

If you get stuck at any point, feel free to checkout an issue here (if its related to the JSON) or on the WipperSnapper Arduino repository (if its related to the firmware or build process) and tag me.

@tyeth
Copy link
Contributor

tyeth commented Sep 21, 2023

Not sure if there was a revision, but I can no longer find the BH1745 as part of a combined PiMoRoNi product. I checked the Enviro range and the basic search:
https://shop.pimoroni.com/search?q=bh17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants