Adding I2C component BH1750 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well shucks, I just realized the sensor I have on hand is the BH1750 and not the BH1745 requested in #116. When I started reading the datasheet, I realized my error. I think if it's reasonable I'd like to finish implementing the BH1750, and then if I can get my hands on a BH1745, I can take a look at implementing that one. |
|
@whatisbyandby Sure, I agree, let's do what's possible for now. I am going to close out this PR for now. When you are ready to implement, you may re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116
Hi, I'd like to try to implement the BH1750 requested in the issue above. I added the component definition, but I'm just starting to implement the driver. I didn't know if I should open the PR here first, and then implement the driver, or if I needed both before opening any PR.
This PR adds the component definition to the Wippersnapper Component library for the BH1750 Light Sensor.
Product Url: https://www.adafruit.com/product/4681