Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of client proof #13

Closed
wants to merge 1 commit into from
Closed

Conversation

abiligiri
Copy link

  • Pad g with 0s to be of size N
  • Add variant for generating client secret that accepts password as data and without username

- Pad g with 0s to be of size N
- Add variant for generating client secret that accepts
  password as data and without username
@adam-fowler
Copy link
Owner

adam-fowler commented Oct 29, 2024

  • Pad g with 0s to be of size N

I don't see anything in the RFC about padding g with zeros before hashing it

  • Add variant for generating client secret that accepts password as data and without username

This is a very odd addition in that passwords are strings. How come you need a password as Data?

EDIT: I take this back. The specification around padding is quite vague. The Mozilla vectors expect padding, so I'll take that as expected. Your PR doesn't cover all the cases. I have another PR that does this #14. If you could verify that is works for you that'd be awesome

@adam-fowler
Copy link
Owner

Now that #14 is merged this is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants