Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: classification NN and CORN NN options #10

Merged
merged 4 commits into from
Mar 23, 2024
Merged

ADD: classification NN and CORN NN options #10

merged 4 commits into from
Mar 23, 2024

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented Mar 22, 2024

this PR adds:

  • Neural Network trained for classification but evaluated with RMSE [1]
  • Neural Network with ordinal regression as implemented in CORN - also evaluated with RMSE [1]
  • increases simulated data sample size

[1] reason: (to remain consistent with regression models)

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 58.30%. Comparing base (d7a3858) to head (786b052).

Files Patch % Lines
q2_ritme/model_space/_static_trainables.py 25.49% 36 Missing and 2 partials ⚠️
q2_ritme/evaluate_models.py 0.00% 13 Missing ⚠️
q2_ritme/simulate_data.py 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   60.94%   58.30%   -2.65%     
==========================================
  Files          17       17              
  Lines         845      897      +52     
  Branches       67       84      +17     
==========================================
+ Hits          515      523       +8     
- Misses        329      369      +40     
- Partials        1        5       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja adamovanja merged commit 202c31f into main Mar 23, 2024
4 checks passed
@adamovanja adamovanja deleted the add_corn branch March 23, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant