Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: L1L2 option, fixed alr idx and relative abundances #14

Merged
merged 5 commits into from
May 1, 2024

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented May 1, 2024

this PR:

  • adds L1 and L2 regularisation options for linear regression through ElasticNet model from ScikitLearn
  • adds fixed alr index to use for all trials to most non-zero feature in train_val
  • enforces feature table to use for modelling to be of relative abundances (not absolute counts)
  • adds model type as metric to MLflow

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 99.45055% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.71%. Comparing base (54a62b6) to head (822d222).

Files Patch % Lines
q2_ritme/tune_models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   57.60%   62.71%   +5.10%     
==========================================
  Files          17       17              
  Lines         920     1046     +126     
  Branches       92       94       +2     
==========================================
+ Hits          530      656     +126     
  Misses        385      385              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja adamovanja changed the title ENH: search space for LinReg and FeatureEngineering ENH: L1L2 option, fixed alr idx and relative abundances May 1, 2024
@adamovanja adamovanja merged commit c208921 into main May 1, 2024
4 checks passed
@adamovanja adamovanja deleted the enh_hyperparams_options branch May 1, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant