Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: refactor model definitions + evaluations #30

Merged
merged 7 commits into from
Sep 2, 2024
Merged

ENH: refactor model definitions + evaluations #30

merged 7 commits into from
Sep 2, 2024

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented Aug 30, 2024

this PR:

  • adds descriptions of ray tune + pytorch logging mismatch bug
  • cleans up model definition + evaluation of NN models
  • cleans up trac model definition
  • adds new unit test for model logging
  • replaces q2lint with ruff linting

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 56 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (cdfd9cd) to head (7b35739).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
q2_ritme/model_space/static_trainables.py 18.96% 47 Missing ⚠️
q2_ritme/evaluate_models.py 0.00% 5 Missing ⚠️
q2_ritme/tune_models.py 25.00% 2 Missing and 1 partial ⚠️
q2_ritme/evaluate_all_experiments.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   49.06%   58.46%   +9.39%     
==========================================
  Files          17       17              
  Lines        1072     1093      +21     
  Branches      160      153       -7     
==========================================
+ Hits          526      639     +113     
+ Misses        534      437      -97     
- Partials       12       17       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja adamovanja changed the title ENH: refactor ENH: refactor model definitions + evaluations Sep 2, 2024
@adamovanja adamovanja merged commit d66b0a1 into main Sep 2, 2024
3 checks passed
@adamovanja adamovanja deleted the refactor branch September 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant