Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Improve evaluation + make CLI runnable #8

Merged
merged 6 commits into from
Mar 3, 2024
Merged

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented Feb 21, 2024

this PR:

  • makes running tuned model experiments runnable via the CLI and a configuration file (see run_n_eval_tune.py)
  • includes refined model evaluation over all experiments (see eval_best_trial_overall.py)
  • refines model evaluation over one experiment
  • loosens codecov threshold restriction while package is still in development

@adamovanja adamovanja changed the title ADD: Improve model evaluation ADD: Improve evaluation + make CLI runnable Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 247 lines in your changes are missing coverage. Please review.

Project coverage is 60.94%. Comparing base (a094e8e) to head (c85d6c4).

Files Patch % Lines
q2_ritme/evaluate_models.py 0.00% 121 Missing ⚠️
q2_ritme/evaluate_all_experiments.py 0.00% 54 Missing ⚠️
q2_ritme/run_n_eval_tune.py 0.00% 46 Missing ⚠️
q2_ritme/eval_best_trial_overall.py 0.00% 23 Missing ⚠️
q2_ritme/tune_models.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #8       +/-   ##
===========================================
- Coverage   84.01%   60.94%   -23.07%     
===========================================
  Files          15       17        +2     
  Lines         613      845      +232     
  Branches       35       67       +32     
===========================================
  Hits          515      515               
- Misses         97      329      +232     
  Partials        1        1               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja adamovanja merged commit c04a710 into main Mar 3, 2024
4 checks passed
@adamovanja adamovanja deleted the improve_evaluation branch March 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant