Add --rdg-scroll-height variable
#3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
- Coverage 98.26% 98.21% -0.06%
==========================================
Files 47 47
Lines 5077 5087 +10
Branches 724 724
==========================================
+ Hits 4989 4996 +7
- Misses 88 91 +3
|
amanmahajan7
changed the title
--rdg-total-height variable--rdg-rows-height variable
nstepien
reviewed
Mar 14, 2024
nstepien
reviewed
Mar 14, 2024
nstepien
reviewed
Mar 14, 2024
src/hooks/useGridDimensions.ts
Outdated
| @@ -7,6 +7,7 @@ export function useGridDimensions() { | |||
| const gridRef = useRef<HTMLDivElement>(null); | |||
| const [inlineSize, setInlineSize] = useState(1); | |||
| const [blockSize, setBlockSize] = useState(1); | |||
| const [horizontalScrollbarWidth, setHorizontalScrollbarWidth] = useState(0); | |||
amanmahajan7
changed the title
--rdg-rows-height variable--rdg-scroll-height variable
- set scrollbar height in resize observer callback
nstepien
approved these changes
Mar 14, 2024
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Add `--rdg-total-height` variable * rename * Handle scrollbar width * `horizontalScrollbarWidth` -> `verticalScrollbarWidth` * Revert "`horizontalScrollbarWidth` -> `verticalScrollbarWidth`" This reverts commit 4dd2a87. * Fix `horizontalScrollbarWidth` * Rename to `--rdg-inner-height` * - rename variables - set scrollbar height in resize observer callback * `innerHeight` -> `scrollHeight`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful to set grid height based on the number of rows. For example we can do something like