MacOS fix: change lxml setup (#114)

* Unpin lxml Per adbar/trafilatura#449, see if unpinning lxml works on MacOS. * specify versions and add platform test * further specify, add tests * reduce number of tests --------- Co-authored-by: Adrien Barbaresi <[email protected]> Co-authored-by: Adrien Barbaresi <[email protected]>
adbar · Dec 22, 2023 · 69310fa · 69310fa
1 parent 4088710
commit 69310fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -27,6 +27,10 @@ jobs:
           python-version: 3.7
         - os: macos-latest
           python-version: 3.8
+        - os: macos-latest
+          python-version: "3.10"
+        - os: macos-latest
+          python-version: "3.12"
         - os: windows-latest
           python-version: 3.8
     steps:

diff --git a/setup.py b/setup.py
@@ -118,8 +118,9 @@ def get_version(package):
         "charset_normalizer >= 3.0.1; python_version < '3.7'",
         "charset_normalizer >= 3.3.2; python_version >= '3.7'",
         "dateparser >= 1.1.2",  # 1.1.3+ slower
-        "lxml >= 4.9.3 ; platform_system != 'Darwin'",
-        "lxml == 4.9.2 ; platform_system == 'Darwin'",
+        # see tests on Github Actions
+        "lxml == 4.9.2 ; platform_system == 'Darwin' and python_version <= '3.8'",
+        "lxml >= 4.9.4 ; platform_system != 'Darwin' or python_version > '3.8'",
         "python-dateutil >= 2.8.2",
         "urllib3 >= 1.26, < 2; python_version < '3.7'",
         "urllib3 >= 1.26, < 3; python_version >= '3.7'",