Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxml pinning / Python 3.12 support for MacOS #113

Closed
efecan-circlelabs opened this issue Dec 4, 2023 · 0 comments · Fixed by #114
Closed

lxml pinning / Python 3.12 support for MacOS #113

efecan-circlelabs opened this issue Dec 4, 2023 · 0 comments · Fixed by #114

Comments

@efecan-circlelabs
Copy link

Hello,

I'm unable to find a reason why lxml is pinned here
https://github.com/adbar/htmldate/blob/master/setup.py#L121-L122

It's breaking my local dev which is running on MacOS and encountering the pinned version which doesn't compile for Python 3.12 (later versions of lxml compile just fine).

For the mean time I've fork'd this repo and removed the pinning.

Please advice, happy to make any required PRs!
Thanks.

@adbar adbar linked a pull request Dec 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant