Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin lxml #114

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Unpin lxml #114

merged 5 commits into from
Dec 22, 2023

Conversation

adamh-oai
Copy link
Contributor

Per adbar/trafilatura#449, see if unpinning
lxml works on MacOS.

Per adbar/trafilatura#449, see if unpinning
lxml works on MacOS.
@adbar adbar linked an issue Dec 8, 2023 that may be closed by this pull request
@adbar
Copy link
Owner

adbar commented Dec 8, 2023

Hi @adamh-oai, the tests pass, the current issue is unrelated, a dummy site is down.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4088710) 99.07% compared to head (b8cc607) 99.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files           8        8           
  Lines         867      867           
=======================================
  Hits          859      859           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar
Copy link
Owner

adbar commented Dec 8, 2023

Now it works for Python 3.12 but not for Python 3.8 on MacOS.

@mde-pach
Copy link

mde-pach commented Dec 14, 2023

I ran the tests locally and everything works well with the same version of python on macos (m2 architecture)
Can this test not works because of the content of the website during the run ?
Did you try to rerun them ?

Edit: I just saw the tests are run using a x86 architecture, maybe the difference come from there

@adbar
Copy link
Owner

adbar commented Dec 15, 2023

Yes, I updated the tests. I'm not sure why tests fail specifically on Python 3.8 but you're probably right in assuming different architectures lead to different outcomes.

We could try adding other versions of Python on MacOS, so far other architectures are not easily available on Github Actions as far as I know.

@adbar
Copy link
Owner

adbar commented Dec 21, 2023

@adamh-oai I believe I found the right combination of settings and tests, what do you think?

@adamh-oai
Copy link
Contributor Author

lgtm!

@adbar adbar merged commit 69310fa into adbar:master Dec 22, 2023
20 checks passed
@adamh-oai
Copy link
Contributor Author

Could you put up a new release on pypi with this change? Thanks!

@adbar
Copy link
Owner

adbar commented Jan 2, 2024

Yes, I plan to do it this week for htmldate and a bit later for trafilatura.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lxml pinning / Python 3.12 support for MacOS
3 participants