-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin lxml #114
Unpin lxml #114
Conversation
Per adbar/trafilatura#449, see if unpinning lxml works on MacOS.
Hi @adamh-oai, the tests pass, the current issue is unrelated, a dummy site is down. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 8 8
Lines 867 867
=======================================
Hits 859 859
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Now it works for Python 3.12 but not for Python 3.8 on MacOS. |
I ran the tests locally and everything works well with the same version of python on macos (m2 architecture) Edit: I just saw the tests are run using a x86 architecture, maybe the difference come from there |
Yes, I updated the tests. I'm not sure why tests fail specifically on Python 3.8 but you're probably right in assuming different architectures lead to different outcomes. We could try adding other versions of Python on MacOS, so far other architectures are not easily available on Github Actions as far as I know. |
@adamh-oai I believe I found the right combination of settings and tests, what do you think? |
lgtm! |
Could you put up a new release on pypi with this change? Thanks! |
Yes, I plan to do it this week for htmldate and a bit later for trafilatura. |
Per adbar/trafilatura#449, see if unpinning
lxml works on MacOS.