Fix various issues and tune some filtering parameters #78

adehecq · 2022-03-31T16:42:00Z

fix small issues with TimeSeries4
rename TimeSeries4 into TimeSeries_full (for clarity)
increase min date difference threshold to at least 4 years
filter steep slopes and disable ill-working NMAD filter
increase bin size to 100 m as in Dussaillant et al (2019) and Hugonnet et al. (2021)

Fixes #71 .

friedrichknuth · 2022-03-31T23:55:18Z

ragmac_xdem/dem_postprocessing.py

@@ -842,7 +840,7 @@ def fname_func(pair_id):
            min_date = np.percentile(ds.time, 2)
            max_date = np.percentile(ds.time, 98)
            time_delta_max = int((max_date - min_date).astype('timedelta64[D]') / np.timedelta64(1, 'D'))
-            time_delta_min = int(time_delta_max * 0.1)
+            time_delta_min = min(4*365, int(time_delta_max * 0.5))


adehecq added 5 commits March 31, 2022 10:47

Rm redundant line

b4dcdfe

Rename TimeSeries4 into TimeSeries_full

93b6e32

Make sure TimeSeries_full is handled properly everywhere

79dfb16

Increase min dt threshold

69a554a

Filter pixels with slope>45, disable nmad filter and use bins of 100 m

c8c8566

adehecq merged commit 75e50b3 into master Mar 31, 2022

friedrichknuth reviewed Mar 31, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix various issues and tune some filtering parameters #78

Fix various issues and tune some filtering parameters #78

adehecq commented Mar 31, 2022

friedrichknuth Mar 31, 2022

Fix various issues and tune some filtering parameters #78

Fix various issues and tune some filtering parameters #78

Conversation

adehecq commented Mar 31, 2022

friedrichknuth Mar 31, 2022

Choose a reason for hiding this comment