Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(misc-apps): pin metallb to 1.13.11 instead of wildcarding the patch version #1136

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore(misc-apps): pin metallb to 1.13.11 instead of wildcarding the patch version #1136

merged 1 commit into from
Nov 10, 2023

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Oct 17, 2023 •
edited
Loading

Description

Pin metallb to a version instead of wildcarding it's patch version.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2023
@hairmare hairmare force-pushed the chore/misc-apps/pin-metallb-version branch from c3ed2e8 to 909bed6 Compare October 17, 2023 13:09
@hairmare hairmare changed the title Chore/misc apps/pin metallb version chore(misc-apps): pin metallb to 1.13.11 instead of wildcarding the patch version Oct 17, 2023
@hairmare hairmare marked this pull request as ready for review October 17, 2023 13:11
@hairmare hairmare requested a review from a team as a code owner October 17, 2023 13:11
@hairmare hairmare requested review from gianklug and vmaillot October 17, 2023 13:11
@hairmare
Copy link
Contributor Author

Let's merge #1135 before this since it was earlier

@hairmare hairmare force-pushed the chore/misc-apps/pin-metallb-version branch from 909bed6 to 16e4817 Compare October 24, 2023 09:55
@hairmare hairmare force-pushed the chore/misc-apps/pin-metallb-version branch from 16e4817 to a0debe9 Compare October 31, 2023 16:57
@hairmare hairmare force-pushed the chore/misc-apps/pin-metallb-version branch from a0debe9 to bc405a3 Compare November 9, 2023 16:33
@hairmare hairmare force-pushed the chore/misc-apps/pin-metallb-version branch from bc405a3 to 69311be Compare November 10, 2023 16:51
gianklug
gianklug approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@gianklug gianklug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairmare hairmare merged commit ce05fbe into adfinis:main Nov 10, 2023
3 checks passed
@hairmare hairmare deleted the chore/misc-apps/pin-metallb-version branch November 10, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianklug gianklug gianklug approved these changes

@vmaillot vmaillot Awaiting requested review from vmaillot vmaillot is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @gianklug