Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra-logging): add extraObjects field #1146

Closed
wants to merge 2 commits into from

Conversation

norbertgruszka
Copy link
Contributor

@norbertgruszka norbertgruszka commented Nov 14, 2023

Description

Latest version of loki helm chart comes with extraObjects variable which can be used to deploy additional resources. However, loki-stack chart must stayed behind, because mentioned variable is not present. Because of that I added extraObjects field to infra-logging chart.

Issues

Unable to deploy additional resources alongside loki-stack.

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2023
@hairmare
Copy link
Contributor

IMO we should do #1058 instead of this

@tongpu
Copy link
Member

tongpu commented Nov 14, 2023

I think before monkeypatching features into logging-apps we should progress with finally replacing loki-stack with loki according to #1058.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@norbertgruszka
Copy link
Contributor Author

@hairmare @tongpu sure thing, didn't know about that issue. Closing this one then.

@norbertgruszka norbertgruszka deleted the feat/logging-apps-extra-resources branch November 14, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants