Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security-apps)!: Bump CSI-Secrets-Driver and Vault Chart version #1153

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Bluekind1
Copy link
Contributor

Description

Bump Vault Helm Chart version from 0.26.1 to 0.27.0
Bump CSI-Secrets-Driver version from 1.3.4 to 1.4.0
!!! Breaking Change for CSI Secrets Driver !!!

total_ prefix in the metrics name has been dropped as part of the latest otel bump in the driver. For Prometheus counters, by default the otel library appends total suffix.

  • total_rotation_reconcile -> rotation_reconcile_total
  • total_rotation_reconcile_error -> rotation_reconcile_error_total
  • total_node_publish -> node_publish_total
  • total_node_unpublish -> node_unpublish_total
  • total_node_publish_error -> node_publish_error_total
  • total_node_unpublish_error -> node_unpublish_error_total
  • total_sync_k8s_secret -> sync_k8s_secret_total

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2023
@Bluekind1 Bluekind1 marked this pull request as ready for review November 24, 2023 14:20
@Bluekind1 Bluekind1 requested a review from a team as a code owner November 24, 2023 14:20
@Bluekind1 Bluekind1 self-assigned this Nov 24, 2023
@pree pree assigned pree and unassigned Bluekind1 and pree Nov 24, 2023
@pree pree removed their assignment Nov 24, 2023
@pree pree changed the title chore(security-apps)\!: Bump CSI-Secrets-Driver and Vault Chart version chore(security-apps)!: Bump CSI-Secrets-Driver and Vault Chart version Nov 24, 2023
@eyenx
Copy link
Member

eyenx commented Nov 24, 2023

I would just put the breaking change inside the annotations as well.

@Bluekind1 Bluekind1 marked this pull request as draft November 24, 2023 14:46
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2023
@Bluekind1 Bluekind1 marked this pull request as ready for review November 24, 2023 15:01
@pree pree merged commit 6951632 into main Nov 27, 2023
3 checks passed
@pree pree deleted the chore/csi-driver-update branch November 27, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants