Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hedgedoc): Create ServiceMonitor resources #1154

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat(hedgedoc): Create ServiceMonitor resources #1154

merged 1 commit into from
Nov 27, 2023

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Nov 27, 2023 •
edited
Loading

Description

Allow creating a ServiceMonitor resource for HedgeDoc.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2023
@hairmare hairmare force-pushed the feat/hedgedoc/servicemonitor branch from 838cfef to 5b01fd2 Compare November 27, 2023 17:08
@hairmare hairmare marked this pull request as ready for review November 27, 2023 17:11
@hairmare hairmare requested a review from luk43 November 27, 2023 17:11
gianklug
gianklug approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@gianklug gianklug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairmare hairmare merged commit 95d89f7 into adfinis:main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianklug gianklug gianklug approved these changes

@altesockensuppe altesockensuppe Awaiting requested review from altesockensuppe altesockensuppe is a code owner

@luk43 luk43 Awaiting requested review from luk43 luk43 is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @gianklug