Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*-apps): Update argoconfig dependency #1173

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

maxthier
Copy link
Contributor

@maxthier maxthier commented Jan 12, 2024

Description

This PR updates the dependencies of argoconfig to argoconfig 0.9.1. This change is needed because when no syncPolicy is defined, it will be set to null what argoCD removes but because of this the application goes out-of-sync. For more informations about this take a look at #1172.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@maxthier maxthier self-assigned this Jan 12, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2024
@eyenx
Copy link
Member

eyenx commented Jan 12, 2024

@maxthier you need to rebuild the Chart.lock using helm dep build and push that to git as well

@maxthier maxthier marked this pull request as ready for review January 12, 2024 09:16
@maxthier maxthier requested a review from a team as a code owner January 12, 2024 09:16
@eyenx
Copy link
Member

eyenx commented Jan 12, 2024

LGTm

@maxthier maxthier merged commit 9857575 into main Jan 12, 2024
3 checks passed
@maxthier maxthier deleted the chore/security-apps-dependencies branch January 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants