-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add charts for shlink and shlink-web #1370
base: main
Are you sure you want to change the base?
Conversation
c8a5f4d
to
10d35f0
Compare
I'll have to find some time for an in depth review, some initial questions
|
A few years ago there were some efforts regarding a chart and the maintainer was interested, but unfortunately the existing helm chart is extremely outdated and unmaintained. See shlinkio/shlink#668
Technically, you don't need |
btw, will take a look at the failing test tomorrow. |
Can you please add the maintainer of this charts to the CODEOWNERs file? Thanks. |
What About @christianhuth charts? They seem updated https://github.com/christianhuth/helm-charts/tree/main/charts I suggest just using those instead of maintaining our own if nothing is against it. |
appVersion: 4.3.0 | ||
home: https://shlink.io | ||
sources: | ||
- https://github.com/shlinkio/shlink-web-client/tree/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: The URL could be canonicalized
- https://github.com/shlinkio/shlink-web-client/tree/main | |
- https://github.com/shlinkio/shlink-web-client/ |
Oh... I did not know this chart existed :(
Both things should be easily fixable, so I guess I'll start working on some PRs. |
Hi guys :) |
Thanks for pointing out that there is no option for using an external database. Will add this with the next release. There is an option to define extra environment variables. As I started with the development of the Chart this seemed like a good approach. Today I would take another approach and make it possible to define common env variables through Value attributes. Is there a list of all env variables supported by shlink? |
Hey @christianhuth, thanks for checking in and maintaining the chart! I saw that you can define extra variables and if christianhuth/helm-charts#1249 gets merged, you could technically configure an external database without exposing any secrets, but I suppose having dedicated values for that might be more idiomatic. All environment variables supported by shlink are documented here and shlink-web supports preconfiguring servers by env vars. |
Will check this out in the next couple of days. |
Description
This PR introduces new charts to deploy shlink and the corresponding web UI "shlink-web".
The chart is will be used in our internal initiative to replace our current URL shortener.
Thanks for the review!
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/