Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to Access Profile API for checking Express entitlement #296

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

askayastha22
Copy link
Member

@askayastha22 askayastha22 commented Aug 5, 2024

Description

Related Issue

https://jira.corp.adobe.com/browse/SITES-20576

Motivation and Context

How Has This Been Tested?

https://experience-qa.adobe.com/?devMode=true&shell_source=dev&shell_ims=prod#/@sitesinternal/aem/generate-variations/

The Generate Image button should be enabled in "Adobe Inc." and "Sites Internal" IMS org and usually disabled in other IMS orgs.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@slitviachenko slitviachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know all the details, but let's give this PR a try 👍

@askayastha22 askayastha22 merged commit 55e0016 into main Aug 7, 2024
3 checks passed
@askayastha22 askayastha22 deleted the SITES-20576_express-fi-check branch August 7, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants