Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-27490: V2 alert #304

Merged
merged 2 commits into from
Jan 16, 2025
Merged

SITES-27490: V2 alert #304

merged 2 commits into from
Jan 16, 2025

Conversation

audrey-kho
Copy link
Contributor

@audrey-kho audrey-kho commented Jan 15, 2025

Description

Related Issue

https://jira.corp.adobe.com/browse/SITES-27490

Motivation and Context

How Has This Been Tested?

https://experience-qa.adobe.com/?devMode=true&shell_source=workspace&workspace=v2alert&shell_ims=prod#/aem/generate-variations/

Screenshots (if appropriate):

Screenshot 2025-01-15 at 3 21 04 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@audrey-kho audrey-kho requested a review from lenaorobei January 16, 2025 18:39
@lenaorobei
Copy link
Collaborator

Do you plan to update the app version in a separate PR?

@audrey-kho
Copy link
Contributor Author

Do you plan to update the app version in a separate PR?

@lenaorobei yes since it's always been done in a separate PR for previous releases

@audrey-kho audrey-kho merged commit 3883951 into main Jan 16, 2025
3 checks passed
@audrey-kho audrey-kho deleted the v2-alert branch January 16, 2025 19:04
@lenaorobei lenaorobei mentioned this pull request Jan 21, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants