Skip to content

Commit

Permalink
Un-pin electron forge (#1391)
Browse files Browse the repository at this point in the history
Probably as a leftover from when it was in beta, the `@electron-forge/core` dependency was pinned. Apparently `@electron-forge/[email protected]` doesn't work with `@electron-forge/[email protected]` (but core's dependency on template-base isn't pinned), so when installing `ember-electron` apps would end up with core v6.0.4 and template-base v6.0.5 and the blueprint wouldn't run. Un-pinning core should prevent this from happening again.

Fixes #1390
  • Loading branch information
bendemboski authored Feb 23, 2023
1 parent 4ca52fe commit e3d330f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test-slow": "mocha node-tests/acceptance/**/*.js"
},
"dependencies": {
"@electron-forge/core": "6.0.5",
"@electron-forge/core": "^6.0.5",
"chalk": "^4.1.2",
"debug": "^4.1.1",
"ember-cli-babel": "^7.26.11",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@
semver "^7.2.1"
yarn-or-npm "^3.0.1"

"@electron-forge/[email protected]":
"@electron-forge/core@^6.0.5":
version "6.0.5"
resolved "https://registry.yarnpkg.com/@electron-forge/core/-/core-6.0.5.tgz#38e8ee4e1f5bbf22934b02b3d202e19dcb2b055f"
integrity sha512-lMtm3x2ZFEBOU7/JTIo2oI5dXm2hKqpdc4opHA7iOxja5YYDDvnqKt+tACJSCdnCOxYLS+0OSoaz/DJ8SNyStw==
Expand Down

0 comments on commit e3d330f

Please sign in to comment.