fake #27
Open
fake #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A condition to ensure the state of the cluster after starting it behind a proxy was introduce in crc-org@4a9a35b that check is using a function which relies on the shell instance but that instance is not initialize anywhere as so the check is failing with an error showing shell instance is not initialize. This commit initialize the instance and now the check is working as expected Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
https://crc.dev/blog/about is no longer works and `about` section is removed, this pr update to latest valid url It will also fix the issue which described in https://community.chocolatey.org/packages/crc/2.34.1#dependencies one.
Currently, when telemetry initialization fails, this is a hard failure for the `crc` command and daemon, and they exit. This commit handles this more gracefully, when there's a telemetry initialization failure, an empty `Noop Client` instance is returned, and all `Client` methods check for this `Noop` instance and return early if needed.
As part of commit crc-org@ae4e57f we changed the e2e and integration images; as ubi9 based images were used to build the e2e and integration binaries those can not be executed on RHEL8 target hosts. This fix change the builders to use ubi8 based images Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
The scripts used to run the integration tests require to set several environment variables to customize the execution; the way the script try to set them and run the integration binary inheriting them was not right. This fix export those variables and execute the integration binary properly Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
….com/ubi8/httpd-24:latest This image was partially used within e2e, now we extend its usage to all the remainig places Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Issue #N
Relates to: Issue #N, PR #N, ...
Solution/Idea
Describe in plain English what you solved and how. For instance, Added
startcommand to CRC so the user can create a VM and set-up a single-node OpenShift cluster on it with one command. It requires blablabla...Proposed changes
List main as well as consequential changes you introduced or had to introduce.
startcommand.setupas prerequisite tostart.Testing
What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.
startsucceeds first time aftersetupsucceededstartsucceededstartfailedstatusreturns ... ifstartsucceededstatusreturns ... ifstartfailedstartfails afterstartsucceeded or afterstatussays CRC isRunning