Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all changes #5

Merged
merged 1 commit into from
Mar 25, 2024
Merged

all changes #5

merged 1 commit into from
Mar 25, 2024

Conversation

adrianriobo
Copy link
Owner

Fixes: Issue #N

Relates to: Issue #N, PR #N, ...

Solution/Idea

Describe in plain English what you solved and how. For instance, Added start command to CRC so the user can create a VM and set-up a single-node OpenShift cluster on it with one command. It requires blablabla...

Proposed changes

List main as well as consequential changes you introduced or had to introduce.

  1. Add start command.
  2. Add setup as prerequisite to start.
  3. ...

Testing

What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.

  1. start succeeds first time after setup succeeded
  2. stdout contains ... if start succeeded
  3. stderr contains ... after start failed
  4. status returns ... if start succeeded
  5. status returns ... if start failed
  6. start fails after start succeeded or after status says CRC is Running
  7. ...

Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
@adrianriobo adrianriobo merged commit 8527630 into main Mar 25, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant