provide androidx.lifecycle.compose.LocalLifecycleOwner in android target #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two
LocalLifecycleOwner
incmp 1.6.10
(1.7.0+ will resolved it):androidx.compose.ui.platform.LocalLifecycleOwner
androidx.lifecycle.compose.LocalLifecycleOwner
As per jetbrains's suggestion:
In the cmp code, wo can find that two
LocalLifecycleOwner
are the same withoutandroidTarget
.skiko:
androidTarget:
For now there are a lot of projects that are starting to use
jetbrains-lifecycle-runtime-compose
, I suggest we can provideandroidx.lifecycle.compose.LocalLifecycleOwner
inandroidTarget
first, and then provide the onlyandroidx.lifecycle.compose.LocalLifecycleOwner
incommonMain
aftercmp 1.7.0
, this ensures that the user's normal use is guaranteed.