-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support zIndex Config for Transition #446
Support zIndex Config for Transition #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this PR is doing more then just adding zIndex support, can you explaim in depth the changes and why they are needed and the use cases for it?
voyager-transitions/src/commonMain/kotlin/cafe/adriel/voyager/transitions/ScreenTransition.kt
Outdated
Show resolved
Hide resolved
voyager-transitions/src/commonMain/kotlin/cafe/adriel/voyager/transitions/ScreenTransition.kt
Show resolved
Hide resolved
voyager-transitions/src/commonMain/kotlin/cafe/adriel/voyager/transitions/ScreenTransition.kt
Outdated
Show resolved
Hide resolved
I want to support animate like this, with zIndex: untitled-ezgif.com-video-to-mp4-converter.1.mp4without zIndex: untitled2-ezgif.com-video-to-mp4-converter.mp4AnimatedContent By default the targetState content will be at the top, so we need to configure the ZIndex to adjust the hierarchy;
For |
voyager-transitions/src/commonMain/kotlin/cafe/adriel/voyager/transitions/ScreenTransition.kt
Outdated
Show resolved
Hide resolved
Can you explain what is this change are different from #445? |
The difference is still the same as enter/exit animation, #445 works for the default animation which needs to configure zIndex, but it's not convenient if it's a screen specific animation which needs to configure zIndex. |
To implement an animation such as the following, we need to use the zindex value.