Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace providesDefault in Navigator with provides and an if check #500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hristogochev
Copy link

This is a workaround for an issue with Compose Multiplatform which prevents theme and system padding updates from happening inside nested navigators.

Fixes #484, #486 and #489.

@DevSrSouza
Copy link
Collaborator

It seems it was fixed and published at Google Jetpack compose androidx.compose.runtime:runtime:1.8.0-alpha06, we can wait until we have a Compose KMP version before seeing if this requires to be merge or suggested to just update Compose.

https://issuetracker.google.com/u/0/issues/374263387

@hristogochev
Copy link
Author

hristogochev commented Nov 14, 2024

Sure, we can wait for the fix to reach Compose Multiplatform instead!

Given that Compose Multiplatform was only released 2 days ago and the usual release cycle for a new major release is around 3-4 months, I think it will take at least 3 months until a release with these fixes is published.
Until then developers can use a fork of Voyager with this pull request to solve the linked issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System WindowInsets Not Consumed on iOS Targets When using Nested Navigators
2 participants