Improve query handling #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 11, 2019 12:37
a. Retry the query that is sent to all connected pools (Redis instances);
b. Add `refresh slots map and retry query` logic for such Redis error
responses as <<"ASK ", _/binary>>, <<"TRYAGAIN ", _/binary>> and
<<"CLUSTERDOWN ", _/binary>>;
c. Return an error to application in case of Redis response errors
like as: "ERR unknown command 'foobar'” or "WRONGTYPE Operation
against a key holding the wrong kind of value", "BUSY Redis is
busy running a script", "NOAUTH Authentication required." and so on ;
d. Add `refresh slots map and retry query ` logic in case of POSIX
error that can related to temporary TCP issues.
…ster into xkulale_pull2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have been implemented in the scope of Redis DB solution integration to the cloud infrastructure for a products of one of the world leading providers of Information and Communication Technologies.
Description:
a. Retry the query that is sent to all connected pools (Redis instances);
b. Add
refresh slots map and retry querylogic for such Redis errorresponses as <<"ASK ", _/binary>>, <<"TRYAGAIN ", _/binary>> and
<<"CLUSTERDOWN ", _/binary>>;
c. Return an error to application in case of Redis response errors
like as: "ERR unknown command 'foobar'” or "WRONGTYPE Operation
against a key holding the wrong kind of value", "BUSY Redis is
busy running a script", "NOAUTH Authentication required." and so on ;
d. Add
refresh slots map and retry querylogic in case of POSIXerror that can related to temporary TCP issues.