Add flow option. Add snap option UI only. #3729
Draft
+68
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
This implements additional upstream features from epub.js.
Which issue is fixed?
TBD - currently in draft. I'm aware of several issues related to epubjs features (we previously tagged these as 'ereader' together.
In-depth Description
In particular this:
I recommend we default snapping to off in the interim, then this draft could be published and we could move settable snapping to its own issue. As-is, this PR fixes a couple issues (one about half-pagination getting stuck, and one about ereaders struggling to render smooth animations), so it'd be to get those merged while still figuring out snapping. If you want to do so I can remove the snap settings UI. This would also need to be merged into the app, I believe it doesn't currently have the settings modal.
How have you tested this?
Tested on Firefox (PC and Android) only with epub files only.
Further testing needed (in particular, other filetypes and clients).
Screenshots
E-Reader settings modal: