Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Dependencies #121

Conversation

honeycomb-cheesecake
Copy link
Contributor

No description provided.

@honeycomb-cheesecake honeycomb-cheesecake marked this pull request as draft September 12, 2024 11:15
@honeycomb-cheesecake honeycomb-cheesecake marked this pull request as ready for review September 12, 2024 17:16
@akiradev
Copy link
Contributor

akiradev commented Sep 12, 2024

Couple of things we could do to drop support for 14 which I agree is the right thing to do:

  • Add engines in package.json and specify a minimum node version of 16. This way the fact we don't support it in this version of the SDK is communicated to consumers and they can use a previous version if they really needed to
  • Remove the CI step that checks node 14

…Also changed build version to 20 as 18 isn't supported.
@honeycomb-cheesecake
Copy link
Contributor Author

I've taken it a bit further and have dropped 16 as well and am specifying node version 20. Looking at EOL, this is more in line with where node is.

akiradev
akiradev previously approved these changes Sep 13, 2024
@honeycomb-cheesecake honeycomb-cheesecake merged commit 2389f84 into master Sep 17, 2024
4 checks passed
@honeycomb-cheesecake honeycomb-cheesecake deleted the simonramzi/sc-60450/management-js-sdk-dependency-spring-cleaning branch September 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants