Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version used in GitHub actions #656

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

xRuiAlves
Copy link
Contributor

@xRuiAlves xRuiAlves commented Apr 22, 2024

We are using github actions versions that, underlying, are using NodeJS 16 (which is mark for deprecation!).
We should bump their versions to the ones using NodeJS 20.

Does this change require an update to the documentation?

No.

Can this PR be safely merged to the target branch after approval?

Yes.

How has this been tested?

Relying on CI.

@xRuiAlves xRuiAlves requested a review from queimadus April 22, 2024 14:03
@xRuiAlves xRuiAlves self-assigned this Apr 22, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@xRuiAlves xRuiAlves requested a review from queimadus April 23, 2024 08:49
@xRuiAlves
Copy link
Contributor Author

Oops, seems like it can't find lts 🤔

Copy link
Contributor

@queimadus queimadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@queimadus queimadus merged commit b92c2f9 into master Apr 23, 2024
14 checks passed
@queimadus queimadus deleted the update/nodejs-version-used-in-github-actions branch April 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants