Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages organization from com.velocidi to com.kevel #745

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

beatriz
Copy link
Contributor

@beatriz beatriz commented Oct 12, 2024

This changes the packages from the com.velocidi to com.kevel organization to reflect the organizational change. For now, it doesn't touch the publishing organization as I still need to figure out some things for that.

After making the change I wondered if we'd want to use adzerk instead to be consistent with the GitHub organization name, what do you think?

I am leaving this with the do not merge label for now, as I know we'd like to get a Pekko update without this impacting its release. I will also try to figure out the publish organization to try to get it all at once.

Does this change relate to existing issues or pull requests?

No.

Does this change require an update to the documentation?

Updated the README docs as well.

How has this been tested?

Relying on CI to validate everything keeps working.

@beatriz beatriz requested review from JD557 and jcazevedo October 12, 2024 11:22
@beatriz beatriz marked this pull request as ready for review October 12, 2024 11:25
@jcazevedo
Copy link
Member

After making the change I wondered if we'd want to use adzerk instead to be consistent with the GitHub organization name, what do you think?

I'd rather not move from one old name (com.velocidi) to another old one (com.adzerk).

Copy link
Member

@jcazevedo jcazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the ball rolling on this!

Can we also rename the **/com/velocidi/* folders to **/com/kevel/*?

@@ -21,7 +21,7 @@
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/

package com.velocidi.apso.hashing;
package com.kevel.apso.hashing;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rollback the other changes in this file? I suspect some unwanted IDE shenanigans went unnoticed here.

@beatriz
Copy link
Contributor Author

beatriz commented Oct 15, 2024

Can we also rename the **/com/velocidi/* folders to **/com/kevel/*?

Yeah, totally missed that 😅 Done!

Copy link
Member

@jcazevedo jcazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jcazevedo jcazevedo merged commit e34e33a into master Oct 16, 2024
14 checks passed
@jcazevedo jcazevedo deleted the rename-organization-to-kevel branch October 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants